markap14 commented on a change in pull request #3681: NIFI-6510 - Analytics 
framework
URL: https://github.com/apache/nifi/pull/3681#discussion_r320894062
 
 

 ##########
 File path: 
nifi-api/src/main/java/org/apache/nifi/controller/status/ConnectionStatus.java
 ##########
 @@ -40,6 +41,13 @@
     private long outputBytes;
     private int maxQueuedCount;
     private long maxQueuedBytes;
+    private long predictionIntervalMillis;
 
 Review comment:
   Not necessarily a 'requirement' but there are quite a field fields here 
being added related to predictions. I wonder if it makes sense to have a 
`BackpressurePrediction` objection instead, that houses these? This would be 
particularly helpful if additional fields are added later, either related to 
backpressure prediction, or some other sort of analytic analysis

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to