markap14 commented on a change in pull request #3681: NIFI-6510 - Analytics
framework
URL: https://github.com/apache/nifi/pull/3681#discussion_r320942330
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/reporting/StandardEventAccess.java
##########
@@ -338,6 +343,23 @@ ProcessGroupStatus getGroupStatus(final ProcessGroup
group, final RepositoryStat
bytesTransferred += connectionStatusReport.getContentSizeIn()
+ connectionStatusReport.getContentSizeOut();
}
+ if (statusAnalyticsEngine != null) {
+ StatusAnalytics statusAnalytics =
statusAnalyticsEngine.getStatusAnalytics(conn.getIdentifier());
+ if (statusAnalytics != null) {
Review comment:
If this evaluates to `false` should we be calling
`connStatus.setPredictionsAvailable(false);`? Or perhaps set it to false above
and allow only this branch to override it to `true`. As-is, we explicitly set
it to `false` if engine is null but leave it unset if `statusAnalytics` is null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
