arpadboda commented on a change in pull request #657: MINIFICPP-1048 - Add
PublishKafka docker tests
URL: https://github.com/apache/nifi-minifi-cpp/pull/657#discussion_r332079403
##########
File path: docker/test/integration/minifi/test/__init__.py
##########
@@ -141,14 +166,21 @@ def log_nifi_output(self):
stats = container.stats(stream=False)
logging.info('Container stats:\n%s', stats)
- def check_output(self, timeout=5):
+ def check_output(self, timeout=5, **kwargs):
"""
Wait for flow output, validate it, and log minifi output.
"""
self.wait_for_output(timeout)
self.log_nifi_output()
+ logging.info(kwargs)
+ if isinstance(self.output_validator, SingleFileOutputValidator) and
'dir' in kwargs:
Review comment:
You can achieve this a bit more simple:
```
if self.segfault:
return false
if isinstance(self.output_validator, FileOutputValidator):
return self.output_validator.validate(dir=kwargs.get('dir', default='')])
return self.output_validator.validate()
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
