arpadboda commented on a change in pull request #657: MINIFICPP-1048 - Add
PublishKafka docker tests
URL: https://github.com/apache/nifi-minifi-cpp/pull/657#discussion_r332072052
##########
File path: docker/test/integration/minifi/test/__init__.py
##########
@@ -213,24 +245,75 @@ def __init__(self, expected_content):
self.valid = False
self.expected_content = expected_content
- def validate(self):
+ def validate(self, dir=''):
- if self.valid:
- return True
+ # TODO: Why did we do this btw?
Review comment:
To avoid validating sg. twice.
In case a validator already passed, we are happy.
Not sure if that really occurs or not, I guess not, so I don't mind this to
be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
