mysunnytime commented on a change in pull request #3676: NIFI-6597 Azure Event
Hub Version Update
URL: https://github.com/apache/nifi/pull/3676#discussion_r333160545
##########
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/eventhub/GetAzureEventHub.java
##########
@@ -312,11 +317,13 @@ public void onScheduled(final ProcessContext context)
throws ProcessException, U
receiverFetchTimeout = null;
}
- final String connectionString = new ConnectionStringBuilder(new
URI("amqps://"+namespace+serviceBusEndpoint), eventHubName, policyName,
policyKey).toString();
- setupReceiver(connectionString);
+ final int numThreads = context.getMaxConcurrentTasks();
+ executor = Executors.newScheduledThreadPool(numThreads);
Review comment:
> @mysunnytime can you please describe what testing/verification has been
done for this?
Sure.
There are three unit test for the three processors (PutAzureEventHub,
GetAzureEventHub, and ConsumeAzureEventHut). They all passes. For this pr, we
just upgraded the Event Hub api version and did not change the functionality,
so no new test added.
We also test the three components from the Nifi GUI to send/receive events
to event hub. Before our updates, processors initialization will fail with
ServiceBusException: TransportException (because it uses a really old version
of Event Hubs Java client, which uses a really old version of Proton-J, which
exhibits this problems when used with current versions of the Java runtime).
After the api upgrade, the three components work as expected. Send/receive was
successful. ApacheNiFi-eventhub version is also successfully send for us to
better understand our customer and provide support.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
