mysunnytime commented on a change in pull request #3676: NIFI-6597 Azure Event
Hub Version Update
URL: https://github.com/apache/nifi/pull/3676#discussion_r336322406
##########
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/eventhub/GetAzureEventHub.java
##########
@@ -312,11 +317,13 @@ public void onScheduled(final ProcessContext context)
throws ProcessException, U
receiverFetchTimeout = null;
}
- final String connectionString = new ConnectionStringBuilder(new
URI("amqps://"+namespace+serviceBusEndpoint), eventHubName, policyName,
policyKey).toString();
- setupReceiver(connectionString);
+ final int numThreads = context.getMaxConcurrentTasks();
+ executor = Executors.newScheduledThreadPool(numThreads);
Review comment:
Great! It's good to let the user specify the thread number. We prefer to add
it later in next pr. And for now, instead of using the
context.getMaxConcurrentTasks() that doubles the threads, we can use a default
thread number of 4, which will be enough for most cases. We will add
description to explaination about the thread pool.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
