turcsanyip commented on a change in pull request #3774: NIFI-6729 - Created AbstractSingleAttributeBasedControllerServiceLook… URL: https://github.com/apache/nifi/pull/3774#discussion_r337113481
########## File path: nifi-nar-bundles/nifi-extension-utils/nifi-service-utils/src/main/java/org/apache/nifi/lookup/AbstractSingleAttributeBasedControllerServiceLookup.java ########## @@ -0,0 +1,177 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions andf + * limitations under the License. + */ +package org.apache.nifi.lookup; + +import org.apache.nifi.annotation.lifecycle.OnDisabled; +import org.apache.nifi.annotation.lifecycle.OnEnabled; +import org.apache.nifi.components.PropertyDescriptor; +import org.apache.nifi.components.ValidationContext; +import org.apache.nifi.components.ValidationResult; +import org.apache.nifi.controller.AbstractControllerService; +import org.apache.nifi.controller.ConfigurationContext; +import org.apache.nifi.controller.ControllerService; +import org.apache.nifi.processor.exception.ProcessException; +import org.apache.nifi.processor.util.StandardValidators; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.Collections; +import java.util.HashMap; +import java.util.HashSet; +import java.util.List; +import java.util.Map; +import java.util.Optional; +import java.util.Set; + +/** + * {@link LookupService} that can select a ControllerService of the given type {@link S}. + * <p> + * Selection is based on a single {@linkplain String} lookup key. + * <p> + * Lookup key is provided as a value in an attribute map (usually coming form a flowfile) + * with a predefined key (see {@link #lookupAttribute()}). + * + * @param <S> The type of service to be looked up + */ +public abstract class AbstractSingleAttributeBasedControllerServiceLookup<S extends ControllerService> extends AbstractControllerService implements LookupService<S> { Review comment: I would not implement `LookupService` by this abstract class. In my understanding, `LookupService` implementations are used for extracting some data (eg. records) from a data store. So a bit different use case. On the other hand, implementing `LookupService` has some side effects here, like the additional dependency on `nifi-lookup-service-api` module or the unused methods / parameters that must be implemented. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
