turcsanyip commented on a change in pull request #3774: NIFI-6729 - Created
AbstractSingleAttributeBasedControllerServiceLook…
URL: https://github.com/apache/nifi/pull/3774#discussion_r337521307
##########
File path:
nifi-nar-bundles/nifi-standard-services/nifi-dbcp-service-bundle/nifi-dbcp-service/src/main/java/org/apache/nifi/dbcp/DBCPConnectionPoolLookup.java
##########
@@ -47,70 +35,19 @@
"dynamically at runtime by tagging flow files with the appropriate
'database.name' attribute.")
@DynamicProperty(name = "The ", value = "JDBC property value",
expressionLanguageScope = ExpressionLanguageScope.NONE,
Review comment:
I see it is an old issue but could you please fix the documentation for
`name` and `description`?
The best would be some generic description that could be copied to the other
/ new implementations (and only change the class name, attribute name, etc.)
The doc from AzureStorageCredentialsControllerServiceLookup might be reused
here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
