phrocker commented on a change in pull request #664: WIP: MINIFICPP-1062 -
Improve FlowFile repository performance by leveraging batching
URL: https://github.com/apache/nifi-minifi-cpp/pull/664#discussion_r337198783
##########
File path: extensions/rocksdb-repos/FlowFileRepository.h
##########
@@ -122,6 +126,21 @@ class FlowFileRepository : public core::Repository,
public std::enable_shared_fr
else
return false;
}
+
+ virtual bool MultiPut(const std::vector<std::tuple<std::string, const
uint8_t *, size_t>> data) {
Review comment:
this looks like good functionality. Why is this WIP? have you proven it in
terms of performance improvements?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
