bbende edited a comment on issue #230: NIFIREG-321 Integrate revision concept into UI, REST API, and service… URL: https://github.com/apache/nifi-registry/pull/230#issuecomment-544674101 @kevdoran pushed one more commit that addresses one of your comments about getting a 400 when the entity didn't exist and should have been a 404. The change adds a check for existence in the service facade during update or delete of a `RevisableEntity`, before entering the revision checking. This way if the entity doesn't exist it will throw a `ResourceNotFoundException` (404), instead of `InvalidRevisionException`. There is a possible race condition where the existence check could pass, and then the entity gets deleted by another request before the original request enters the revision check. This would be extremely rare and would produce an `InvalidRevisionException`, at which point the client refreshes and the entity would be gone.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
