bakaid commented on a change in pull request #672: MINIFICPP-1043 - FetchOPC
should support reporting changes only
URL: https://github.com/apache/nifi-minifi-cpp/pull/672#discussion_r342459149
##########
File path: extensions/opc/include/fetchopc.h
##########
@@ -91,10 +92,12 @@ class FetchOPCProcessor : public BaseOPCProcessor {
uint32_t nodesFound_;
uint32_t variablesFound_;
uint64_t maxDepth_;
+ bool lazy_mode_;
private:
std::mutex onTriggerMutex_;
std::vector<UA_NodeId> translatedNodeIDs_; // Only used when user provides
path, path->nodeid translation is only done once
+ std::map<std::string, std::string> node_timestamp_; // Key = Full path,
Value = Timestamp
Review comment:
I think this would be better as an unordered_map - we don't need ordering
and it is potentially very large.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
