bakaid commented on a change in pull request #672: MINIFICPP-1043 - FetchOPC 
should support reporting changes only
URL: https://github.com/apache/nifi-minifi-cpp/pull/672#discussion_r342451080
 
 

 ##########
 File path: extensions/opc/src/fetchopc.cpp
 ##########
 @@ -65,13 +65,20 @@ namespace processors {
       ->withDescription("Specifiec the max depth of browsing. 0 means 
unlimited.")
       ->withDefaultValue<uint64_t>(0)->build());
 
+  core::Property FetchOPCProcessor::Lazy(
 
 Review comment:
   I think it would be better to have a default (default "Off") here, this way 
we would not break previous configurations and make it easier to configure new 
ones.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to