bakaid commented on a change in pull request #681: MINIFICPP-1085
URL: https://github.com/apache/nifi-minifi-cpp/pull/681#discussion_r346397191
##########
File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
##########
@@ -135,14 +152,22 @@ ConsumeWindowsEventLog::ConsumeWindowsEventLog(const
std::string& name, utils::I
} else {
LogWindowsError();
}
+
+ writeXML_ = false;
+ writePlainText_ = false;
+
+ pBookmark_ = std::make_unique<Bookmark>(getUUIDStr(), logger_);
+ if (!*pBookmark_) {
+ pBookmark_.release();
Review comment:
`release()` releases the managed object, but does not free it, therefore,
this will leak. I think `reset()` should be used here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
