bakaid commented on a change in pull request #681: MINIFICPP-1085
URL: https://github.com/apache/nifi-minifi-cpp/pull/681#discussion_r346403490
 
 

 ##########
 File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
 ##########
 @@ -258,92 +389,65 @@ bool ConsumeWindowsEventLog::subscribe(const 
std::shared_ptr<core::ProcessContex
     logger_->log_info("inactiveDurationToReconnect: [%lld] ms", 
inactiveDurationToReconnect_);
   }
 
+  if (!pBookmark_) {
+    logger_->log_error("!pBookmark_");
+    return false;
+  }
+
+  auto channel = std::wstring(channel_.begin(), channel_.end());
+  auto query = std::wstring(query_.begin(), query_.end());
+
+  [&channel, &query, this]() {
 
 Review comment:
   What is the purpose of this lambda if it is unnamed and called right away?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to