belugabehr commented on issue #3915: NIFI-6926: Fixed memory leak in 
NiFiAtlasHook
URL: https://github.com/apache/nifi/pull/3915#issuecomment-561938005
 
 
   Hello @turcsanyip 
   
   I hope you will consider another solution:
   
   
https://github.com/belugabehr/nifi/blob/6c224dbf08731f6d90366911f3e0aaf24c5010bd/nifi-nar-bundles/nifi-atlas-bundle/nifi-atlas-reporting-task/src/main/java/org/apache/nifi/atlas/hook/NiFiAtlasHook.java
   
   I have implemented this change with a `BlockingQueue` because I believe 
adding to the collection and submitting it for processing can occur on 
different threads... it makes sense that it would: thread from repository is 
filling it and every N minutes, a new thread sends out the messages.  Also 
allows one to re-use the queue (don't have to replace it every iteration).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to