belugabehr commented on issue #3915: NIFI-6926: Fixed memory leak in 
NiFiAtlasHook
URL: https://github.com/apache/nifi/pull/3915#issuecomment-562179345
 
 
   @turcsanyip Thank you for the review!  I actually liked your first solution 
of using `clear()` better because I think using immutable values are easier to 
work with when debugging.  Sorry to nit, but could you please consider 
reverting back to using `clear()`?  Perhaps you can make a copy of the list and 
pass the copy into the method before calling `clear()`, but if you're confident 
that the `send` method is synchronous, then you don't even need to make  a copy 
of the list.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to