arpadboda commented on a change in pull request #697: MINIFICPP-1104 - SSL 
docker tests for PublishKafka
URL: https://github.com/apache/nifi-minifi-cpp/pull/697#discussion_r358222087
 
 

 ##########
 File path: docker/test/integration/minifi/test/__init__.py
 ##########
 @@ -291,11 +292,13 @@ def validate(self):
         if self.containers is None:
             return self.valid
 
-        if 'kafka-consumer' not in self.containers:
-            logging.info('Not found kafka container.')
-            return False
+        if 'plain-consumer' in self.containers:
+            kafka_container = self.containers['plain-consumer']
+        elif 'ssl-consumer' in self.containers:
+            kafka_container = self.containers['ssl-consumer']
         else:
-            kafka_container = self.containers['kafka-consumer']
+            logging.info('Not found any kafka consumer.')
 
 Review comment:
   Just fancy, but "no kafka consumer was found" sounds a bit more common. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to