arpadboda commented on a change in pull request #697: MINIFICPP-1104 - SSL
docker tests for PublishKafka
URL: https://github.com/apache/nifi-minifi-cpp/pull/697#discussion_r358218460
##########
File path: docker/test/integration/minifi/__init__.py
##########
@@ -277,6 +284,19 @@ def build_image(self, dockerfile, context_files):
return configured_image
+ def build_image_by_path(self, dir, name=None):
+ try:
+ logging.info('Creating configured image...')
+ configured_image = self.client.images.build(path=dir,
+ tag=name,
+ rm=True,
+ forcerm=True)
+ logging.info('Created image with id: %s', configured_image[0].id)
+ self.images.append(configured_image)
+ return configured_image
+ except Exception as e:
+ logging.info(e)
Review comment:
Either throw it again here or return something.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
