bakaid commented on a change in pull request #706: MINIFICPP-1116 - Fix error
reporting in C2Agent
URL: https://github.com/apache/nifi-minifi-cpp/pull/706#discussion_r364713558
##########
File path: libminifi/src/c2/C2Agent.cpp
##########
@@ -232,7 +232,7 @@ void C2Agent::configure(const std::shared_ptr<Configure>
&configure, bool reconf
if (configure->get("nifi.c2.agent.heartbeat.reporter.classes",
"c2.agent.heartbeat.reporter.classes", heartbeat_reporters)) {
std::vector<std::string> reporters =
utils::StringUtils::split(heartbeat_reporters, ",");
std::lock_guard<std::mutex> lock(heartbeat_mutex);
- for (auto reporter : reporters) {
+ for (const auto& reporter : reporters) {
Review comment:
👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
