bakaid commented on a change in pull request #706: MINIFICPP-1116 - Fix error
reporting in C2Agent
URL: https://github.com/apache/nifi-minifi-cpp/pull/706#discussion_r364712240
##########
File path: libminifi/include/c2/C2Agent.h
##########
@@ -57,7 +57,8 @@ class C2Agent : public state::UpdateController, public
state::response::Response
C2Agent(const std::shared_ptr<core::controller::ControllerServiceProvider>
&controller, const std::shared_ptr<state::StateMonitor> &updateSink, const
std::shared_ptr<Configure> &configure);
- virtual ~C2Agent() {
+ ~C2Agent() noexcept override {
Review comment:
In libminifi code we currently don't use override, as there were some
problems with it on older systems and it has not yet been thoroughly verified
that it works OK now. (In extensions, it is okay.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
