arpadboda commented on a change in pull request #721: MINIFICPP-1135 - Add a
watchdog to schedulingAgent to warn in case of…
URL: https://github.com/apache/nifi-minifi-cpp/pull/721#discussion_r373582179
##########
File path: libminifi/include/SchedulingAgent.h
##########
@@ -190,11 +207,27 @@ class SchedulingAgent {
std::shared_ptr<core::controller::ControllerServiceProvider>
controller_service_provider_;
private:
+ struct SchedulingInfo {
+ std::chrono::time_point<std::chrono::steady_clock> start_time_ =
std::chrono::steady_clock::now();
+ mutable std::chrono::time_point<std::chrono::steady_clock>
last_alert_time_ = std::chrono::steady_clock::now();
Review comment:
I don't think it's a lie.
It think it depends on preference, in my opinion marking some helper members
mutable and maintaining const correctness is better than having a lot of
non-const functions that look like they should have been.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
