arpadboda commented on a change in pull request #721: MINIFICPP-1135 - Add a watchdog to schedulingAgent to warn in case of… URL: https://github.com/apache/nifi-minifi-cpp/pull/721#discussion_r373595822
########## File path: libminifi/include/SchedulingAgent.h ########## @@ -39,6 +41,9 @@ #include "core/controller/ControllerServiceProvider.h" #include "core/controller/ControllerServiceNode.h" +#define SCHEDULING_WATCHDOG_CHECK_PERIOD 1000 // msec +#define SCHEDULING_WATCHDOG_ALERT_PERIOD 5000 // msec Review comment: That should be the default value to avoid hardcoded numbers in the code. Fixed, renamed. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
