szaszm commented on a change in pull request #710: MINIFICPP - 1110,1111 -
PublishKafka, OPC processors should config and
URL: https://github.com/apache/nifi-minifi-cpp/pull/710#discussion_r375878858
##########
File path: libminifi/include/core/state/Value.h
##########
@@ -87,6 +88,15 @@ class Value {
type_id = std::type_index(typeid(T));
}
+ virtual bool getValue(uint32_t &ref) {
+ const auto negative = string_value.find_first_of('-') != std::string::npos;
Review comment:
@arpadboda: The name helps readability and since it's `const` it doesn't
increase complexity. (by potentially introducing extra states)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
