arpadboda commented on a change in pull request #710: MINIFICPP - 1110,1111 -
PublishKafka, OPC processors should config and
URL: https://github.com/apache/nifi-minifi-cpp/pull/710#discussion_r375895619
##########
File path: libminifi/include/core/state/Value.h
##########
@@ -188,6 +264,18 @@ class BoolValue : public Value {
}
}
+ virtual bool getValue(uint32_t &ref) {
Review comment:
The implementation is also bad smell, I agree, didn't check that.
In case the functions are virtual we should introduce a templated private
helper and call that from the virtuals. Still better than 4 times duplicated
code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
