arpadboda commented on a change in pull request #728: MINIFICPP-1147
Implemented.
URL: https://github.com/apache/nifi-minifi-cpp/pull/728#discussion_r376123663
##########
File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp
##########
@@ -226,20 +229,32 @@ void ConsumeWindowsEventLog::onSchedule(const
std::shared_ptr<core::ProcessConte
}
}
+ std::string mode;
+ context->getProperty(OutputFormat.getName(), mode);
+
+ writeXML_ = (mode == Both || mode == XML);
+
+ writePlainText_ = (mode == Both || mode == Plaintext);
+
+ if (writeXML_) {
+ char systemDir[MAX_PATH];
+ if (GetSystemDirectory(systemDir, sizeof(systemDir))) {
+ hMsobjsDll_ = LoadLibrary((systemDir +
std::string("\\msobjs.dll")).c_str());
+ if (!hMsobjsDll_) {
Review comment:
It's nice to have error handling here, although we should make sure not to
call "FormatMessage" later in case this dll open failed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
