arpadboda commented on a change in pull request #728: MINIFICPP-1147 Implemented. URL: https://github.com/apache/nifi-minifi-cpp/pull/728#discussion_r376129464
########## File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp ########## @@ -286,6 +301,103 @@ wel::WindowsEventLogHandler ConsumeWindowsEventLog::getEventLogHandler(const std return providers_[name]; } + +// !!! Used a non-documented approach to resolve `%%` in XML via C:\Windows\System32\MsObjs.dll. +// Links which mention this approach: +// https://social.technet.microsoft.com/Forums/Windows/en-US/340632d1-60f0-4cc5-ad6f-f8c841107d0d/translate-value-1833quot-on-impersonationlevel-and-similar-values?forum=winservergen +// https://github.com/libyal/libevtx/blob/master/documentation/Windows%20XML%20Event%20Log%20(EVTX).asciidoc +// https://stackoverflow.com/questions/33498244/marshaling-a-message-table-resource +// +// Traverse xml and check each node, if it starts with '%%' and contains only digits, use it as key to lookup value in C:\Windows\System32\MsObjs.dll. +void ConsumeWindowsEventLog::substituteXMLPercentageItems(pugi::xml_document& doc) { + if (!hMsobjsDll_) { + return; + } + + struct TreeWalker: public pugi::xml_tree_walker { + TreeWalker(HMODULE hMsobjsDll, std::unordered_map<std::string, std::string>& xmlPercentageItemsResolutions, std::shared_ptr<logging::Logger> logger) + : hMsobjsDll_(hMsobjsDll), xmlPercentageItemsResolutions_(xmlPercentageItemsResolutions), logger_(logger) { + } + + bool for_each(pugi::xml_node& node) override { + const std::string& nodeText = node.text().get(); + + auto beginNumberPos = nodeText.find("%%", 0); Review comment: It also begins with that, but ok. You can still use stoul to convert, that drops he rest (from the first non-digit char) of the string. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
