szaszm commented on a change in pull request #732: MINIFICPP-1013 URL: https://github.com/apache/nifi-minifi-cpp/pull/732#discussion_r377599401
########## File path: win_build_vs.bat ########## @@ -22,10 +22,12 @@ if [%1]==[] goto usage set builddir=%1 set skiptests=OFF set cmake_build_type=Release +set build_type=Release Review comment: Now that we have `built_type`, what do we use `cmake_build_type` for? Was this introduced with the rebase? Because I remember @bakaid removing something like that not long ago. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
