arpadboda commented on a change in pull request #732: MINIFICPP-1013 URL: https://github.com/apache/nifi-minifi-cpp/pull/732#discussion_r377666920
########## File path: extensions/sql/services/DatabaseService.h ########## @@ -0,0 +1,116 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +#ifndef LIBMINIFI_INCLUDE_CONTROLLERS_DATABASESERVICE_H_ +#define LIBMINIFI_INCLUDE_CONTROLLERS_DATABASESERVICE_H_ + +#include "core/logging/LoggerConfiguration.h" +#include "core/controller/ControllerService.h" +#include "data/DatabaseConnectors.h" +#include <memory> +#include <unordered_map> + +#include <soci/soci.h> + +namespace org { +namespace apache { +namespace nifi { +namespace minifi { +namespace sql { +namespace controllers { + +/** + * Purpose and Justification: Controller services function as a layerable way to provide + * services to internal services. While a controller service is generally configured from the flow, + * we want to follow the open closed principle and provide Database services + */ +class DatabaseService : public core::controller::ControllerService { + public: + + /** + * Constructors for the controller service. + */ + explicit DatabaseService(const std::string &name, const std::string &id) + : ControllerService(name, id), + initialized_(false), + logger_(logging::LoggerFactory<DatabaseService>::getLogger()) { + initialize(); + } + + explicit DatabaseService(const std::string &name, utils::Identifier uuid = utils::Identifier()) + : ControllerService(name, uuid), + initialized_(false), + logger_(logging::LoggerFactory<DatabaseService>::getLogger()) { + initialize(); + } + + explicit DatabaseService(const std::string &name, const std::shared_ptr<Configure> &configuration) + : ControllerService(name), + initialized_(false), + logger_(logging::LoggerFactory<DatabaseService>::getLogger()) { + setConfiguration(configuration); + initialize(); + } + + /** + * Parameters needed. + */ + static core::Property ConnectionString; + + virtual void initialize() override; + + void yield() override { + + } + + bool isRunning() override { + return getState() == core::controller::ControllerServiceState::ENABLED; + } + + bool isWorkAvailable() override { + return false; + } + + virtual void onEnable() override; + + virtual std::unique_ptr<sql::Connection> getConnection() const = 0; + + protected: + + void initializeProperties(); + + // initialization mutex. + std::recursive_mutex initialization_mutex_; Review comment: I also think that recursive mutex is a bad smell, but the usage looks correct here, so let's just create a follow-up for this. Created https://issues.apache.org/jira/browse/MINIFICPP-1156 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
