arpadboda commented on a change in pull request #734: MINIFICPP-1157 Implement
lightweight C2 heartbeat.
URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378143506
##########
File path: libminifi/src/FlowController.cpp
##########
@@ -931,6 +942,35 @@ int16_t
FlowController::getMetricsNodes(std::vector<std::shared_ptr<state::respo
return 0;
}
+int16_t
FlowController::getManifestNodes(std::vector<std::shared_ptr<state::response::ResponseNode>>&
manifest_vector, uint16_t metricsClass) {
+ std::lock_guard<std::mutex> lock(metrics_mutex_);
+ (void)metricsClass;
+ for (auto metric : agent_information_) {
Review comment:
const auto& to avoid copy?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
