szaszm commented on a change in pull request #734: MINIFICPP-1157 Implement
lightweight C2 heartbeat.
URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378230978
##########
File path: libminifi/include/core/state/nodes/AgentInformation.h
##########
@@ -643,16 +704,7 @@ class AgentInformation : public DeviceInformation, public
AgentMonitor, public A
}
std::vector<SerializedResponseNode> serialize() {
Review comment:
Can the `serialize()` member functions be marked as `const`? They don't seem
to mutate the object.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
