msharee9 commented on a change in pull request #734: MINIFICPP-1157 Implement
lightweight C2 heartbeat.
URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378441353
##########
File path: libminifi/include/core/state/nodes/AgentInformation.h
##########
@@ -623,18 +632,70 @@ class AgentManifest : public DeviceInformation {
};
/**
- * Purpose and Justification: Prints classes along with their properties for
the current agent.
+ * This class is used for regular heartbeat without manifest
+ * A light weight heartbeat
*/
-class AgentInformation : public DeviceInformation, public AgentMonitor, public
AgentIdentifier {
+class AgentInformationWithoutManifest : public DeviceInformation, public
AgentMonitor, public AgentIdentifier {
Review comment:
Did not understand why it does not fit is-a relationship to any of its base
classes. Can you give example?
No this cannot become a free function unless we change the way we register
and load classes.
This instantiation of this class and other class (AgentInformation) depends
on configuration of root node classes in "nifi.c2.root.classes" property that
are loaded during C2 initialization in FlowController. I want to keep it that
way and be consistent with the existing code base.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
