pvillard31 commented on a change in pull request #4053: NIFI-7142: 
Automatically handle schema drift in the PutKudu processor
URL: https://github.com/apache/nifi/pull/4053#discussion_r379230777
 
 

 ##########
 File path: 
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/main/java/org/apache/nifi/processors/kudu/PutKudu.java
 ##########
 @@ -348,6 +397,14 @@ private void trigger(final ProcessContext context, final 
ProcessSession session,
         session.adjustCounter("Records Inserted", totalCount, false);
     }
 
+    private String getEvaluatedProperty(PropertyDescriptor property, 
ProcessContext context, FlowFile flowFile) {
 
 Review comment:
   I believe that with this approach a flow file not having the expected 
attribute will be sent back to the input relationship and the processor will 
keep processing the same flow file and failing. It should probably be handled 
separately and sent to the failure relationship because it'll always fail with 
this "bad" flow file.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to