granthenke commented on a change in pull request #4053: NIFI-7142: 
Automatically handle schema drift in the PutKudu processor
URL: https://github.com/apache/nifi/pull/4053#discussion_r379440456
 
 

 ##########
 File path: 
nifi-nar-bundles/nifi-kudu-bundle/nifi-kudu-processors/src/main/java/org/apache/nifi/processors/kudu/PutKudu.java
 ##########
 @@ -348,6 +397,14 @@ private void trigger(final ProcessContext context, final 
ProcessSession session,
         session.adjustCounter("Records Inserted", totalCount, false);
     }
 
+    private String getEvaluatedProperty(PropertyDescriptor property, 
ProcessContext context, FlowFile flowFile) {
 
 Review comment:
   This method is called in a try/catch that marks the flowfile as failed and 
then transfers it to the failure relationship. 
   
   ```
   ...
   } catch (Exception ex) {
      flowFileFailures.put(flowFile, ex);
   }             
   ...
   if (flowFileFailures.containsKey(flowFile)) {
      getLogger().error("Failed to write due to {}", new 
Object[]{flowFileFailures.get(flowFile)});
      session.transfer(flowFile, REL_FAILURE);
   ...
   ```
   
   Does that result in the correct behavior?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to