bakaid commented on a change in pull request #734: MINIFICPP-1157 Implement
lightweight C2 heartbeat.
URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r385037599
##########
File path: conf/minifi.properties
##########
@@ -51,7 +51,7 @@
nifi.database.content.repository.directory.default=${MINIFI_HOME}/content_reposi
#nifi.c2.flow.base.url=
#nifi.c2.rest.url=
#nifi.c2.rest.url.ack=
-nifi.c2.root.classes=DeviceInfoNode,AgentInformation,FlowInformation
+nifi.c2.root.classes=DeviceInfoNode,AgentInformationWithoutManifest,FlowInformation
Review comment:
I think changing this by default could cause problems.
If someone wants to use an older C2 server with newer agents without
adapting the C2 server to send DESCRIBE manifest requests when needed would
have their workflow broken.
I think the possibility of changing to lightweight heartbeats should be
documented in `C2.md`, and even a commented out line here with a
`nifi.c2.root.classes` containing `AgentInformationWithoutManifest` (and an
explanation of what it does) would be fine, but changing it by default does not
seem safe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
