bakaid commented on a change in pull request #734: MINIFICPP-1157 Implement
lightweight C2 heartbeat.
URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r384998966
##########
File path: libminifi/include/core/state/nodes/AgentInformation.h
##########
@@ -80,7 +80,7 @@ class ComponentManifest : public DeviceInformation {
return CoreComponent::getName();
}
- virtual std::vector<SerializedResponseNode> serialize() {
+ virtual std::vector<SerializedResponseNode> serialize() const {
Review comment:
While I agree with this modification, it breaks API, which we can't do in a
minor release.
Anyone's code who has implemented a ResponseNode would fail to compile with
this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
