szaszm commented on a change in pull request #735: MINIFICPP-1158 - Event
driven processors can starve each other
URL: https://github.com/apache/nifi-minifi-cpp/pull/735#discussion_r385278922
##########
File path: libminifi/include/ThreadedSchedulingAgent.h
##########
@@ -73,6 +73,8 @@ class ThreadedSchedulingAgent : public SchedulingAgent {
ThreadedSchedulingAgent(const ThreadedSchedulingAgent &parent);
ThreadedSchedulingAgent &operator=(const ThreadedSchedulingAgent &parent);
std::shared_ptr<logging::Logger> logger_;
+
+ std::set<std::string> processors_running_;
Review comment:
No offense, that's a good reason to use a different container. All I'm
asking for is a code comment explaining the above for future readers.
e.g.: `// std::set for easy erase by value`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
