szaszm commented on a change in pull request #735: MINIFICPP-1158 - Event
driven processors can starve each other
URL: https://github.com/apache/nifi-minifi-cpp/pull/735#discussion_r385290235
##########
File path: libminifi/src/FlowController.cpp
##########
@@ -313,21 +310,23 @@ void FlowController::load(const
std::shared_ptr<core::ProcessGroup> &root, bool
controller_service_provider_ =
flow_configuration_->getControllerServiceProvider();
+ auto base_shared_ptr =
std::dynamic_pointer_cast<core::controller::ControllerServiceProvider>(shared_from_this());
Review comment:
No conversion is necessary here since conversion to base class ptr is
implicit. If we want to make it explicit, then `static_pointer_cast` is
sufficient.
Suggestion: inline `shared_from_this()` in place of every usage of
`base_shared_ptr`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
