bakaid commented on a change in pull request #605: MINIFICPP-550 - Implement 
RocksDB controller service and component st…
URL: https://github.com/apache/nifi-minifi-cpp/pull/605#discussion_r390714137
 
 

 ##########
 File path: libminifi/src/c2/C2Agent.cpp
 ##########
 @@ -435,6 +437,27 @@ void C2Agent::handle_c2_server_response(const 
C2ContentResponse &resp) {
         update_sink_->drainRepositories();
         C2Payload response(Operation::ACKNOWLEDGE, resp.ident, false, true);
         enqueue_c2_response(std::move(response));
+      } else if (resp.name == "corecomponentstate") {
 
 Review comment:
   This has only been written to make sure that it fits the architecture, it 
hasn't even been tested manually. Once 
https://github.com/apache/nifi-minifi-cpp/pull/743 is done and merged, I can 
probably write reasonable tests for it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to