bakaid commented on a change in pull request #605: MINIFICPP-550 - Implement
RocksDB controller service and component st…
URL: https://github.com/apache/nifi-minifi-cpp/pull/605#discussion_r393555662
##########
File path: extensions/windows-event-log/Bookmark.cpp
##########
@@ -222,7 +184,7 @@ bool Bookmark::getBookmarkXmlFromFile(std::wstring&
bookmarkXml) {
if (std::wstring::npos == pos) {
logger_->log_error("No '!' in bookmarXml '%ls'", bookmarkXml.c_str());
bookmarkXml.clear();
- return createEmptyBookmarkXmlFile();
+ return false;
Review comment:
Thanks, since these are Windows-only, I edited them in VS when migrating
them, and well... this is the result.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
