markap14 commented on a change in pull request #4120: NIFI-7221 Support v2/v3
protocols with HWX Schema Registry
URL: https://github.com/apache/nifi/pull/4120#discussion_r395321123
##########
File path:
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-standard-record-utils/src/main/java/org/apache/nifi/schema/access/HortonworksAttributeSchemaReferenceWriter.java
##########
@@ -22,16 +22,29 @@
import java.io.IOException;
import java.io.OutputStream;
-import java.util.EnumSet;
import java.util.HashMap;
import java.util.Map;
import java.util.Set;
public class HortonworksAttributeSchemaReferenceWriter implements
SchemaAccessWriter {
- private static final Set<SchemaField> requiredSchemaFields =
EnumSet.of(SchemaField.SCHEMA_IDENTIFIER, SchemaField.SCHEMA_VERSION);
- static final int LATEST_PROTOCOL_VERSION = 1;
+
static final String SCHEMA_BRANCH_ATTRIBUTE = "schema.branch";
+ private final Integer protocolVersion;
+
+ public HortonworksAttributeSchemaReferenceWriter(final Integer
protocolVersion) {
Review comment:
If `protocolVersion` cannot be null, is there a reason to make it an
`Integer` instead of an `int`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
