markap14 commented on a change in pull request #4120: NIFI-7221 Support v2/v3
protocols with HWX Schema Registry
URL: https://github.com/apache/nifi/pull/4120#discussion_r395321816
##########
File path:
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-standard-record-utils/src/main/java/org/apache/nifi/schema/access/HortonworksEncodedSchemaReferenceWriter.java
##########
@@ -24,31 +24,60 @@
import java.io.OutputStream;
import java.nio.ByteBuffer;
import java.util.Collections;
-import java.util.EnumSet;
import java.util.Map;
-import java.util.OptionalInt;
-import java.util.OptionalLong;
import java.util.Set;
public class HortonworksEncodedSchemaReferenceWriter implements
SchemaAccessWriter {
- private static final Set<SchemaField> requiredSchemaFields =
EnumSet.of(SchemaField.SCHEMA_IDENTIFIER, SchemaField.SCHEMA_VERSION);
- private static final int LATEST_PROTOCOL_VERSION = 1;
+
+ private final Integer protocolVersion;
+
+ public HortonworksEncodedSchemaReferenceWriter(final Integer
protocolVersion) {
Review comment:
If the `protocolVersion` cannot be null, should this just be an `int`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
