szaszm commented on issue #731: MINIFICPP-1096 fix BackTrace, OOB indexing, tests, appveyor reporting URL: https://github.com/apache/nifi-minifi-cpp/pull/731#issuecomment-603936391 The issue is that the C2 heartbeat is sometimes missing agentInfo in those test cases. Since it's likely to be because of the referenced bug, I'm ok with handling it there. I'd prefer not to waste effort on debugging it in context of this PR until the referenced issue is fixed. I'm indifferent on whether we should merge this PR on not before MINIFICPP-1172 is resolved, but I'm against closing the Jira ticket until the CI is stable. If MINIFICPP-1172 doesn't solve the issue, a followup PR/commits are the right way to fix the C2 heartbeat flickers IMO.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
