szaszm commented on a change in pull request #731: MINIFICPP-1096 fix
BackTrace, OOB indexing, tests, appveyor reporting
URL: https://github.com/apache/nifi-minifi-cpp/pull/731#discussion_r386439462
##########
File path: libminifi/include/utils/file/FileUtils.h
##########
@@ -112,31 +112,28 @@ class FileUtils {
#endif
}
- static std::string create_temp_directory(char *format) {
+ static std::string create_temp_directory(char * const format) {
#ifdef WIN32
- std::string tempDirectory;
- char tempBuffer[MAX_PATH];
- auto ret = GetTempPath(MAX_PATH, tempBuffer);
- if (ret <= MAX_PATH && ret != 0)
- {
- static std::shared_ptr<minifi::utils::IdGenerator> generator;
- if (!generator) {
- generator =
minifi::utils::IdGenerator::getIdGenerator();
-
generator->initialize(std::make_shared<minifi::Properties>());
- }
- tempDirectory = tempBuffer;
- minifi::utils::Identifier id;
- generator->generate(id);
- tempDirectory += id.to_string();
- create_dir(tempDirectory);
- }
- return tempDirectory;
+ std::string tempDirectory;
+ char tempBuffer[MAX_PATH];
+ auto ret = GetTempPath(MAX_PATH, tempBuffer);
+ if (ret <= MAX_PATH && ret != 0)
+ {
+ static std::shared_ptr<minifi::utils::IdGenerator> generator;
Review comment:
rewritten definition and fixed a possible data race in `IdGenerator`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
