joewitt commented on a change in pull request #4278:
URL: https://github.com/apache/nifi/pull/4278#discussion_r426155221



##########
File path: 
nifi-nar-bundles/nifi-ignite-bundle/nifi-ignite-processors/src/test/resources/test-default-ignite-client.xml
##########
@@ -41,4 +37,12 @@
             </bean>
         </property>
     </bean>
+
+    <bean abstract="true" id="thinIgniteClient" 
class="org.apache.ignite.configuration.ClientConfiguration">
+        <property name="addresses">
+            <list>
+                <value>127.0.0.1:10800</value>

Review comment:
       having statically defined ports in tests almost always is a recipe for 
spurious failures.  if any other test is running at this time on this port then 
it will fail.  I'm not sure if there is an option to adjust this but if not we 
need to ensure none of these tests actually use this port as unit tests - only 
integration tests.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to