joewitt commented on pull request #4278: URL: https://github.com/apache/nifi/pull/4278#issuecomment-629648804
@matthew-formosa-gig the tests all pass and the effort put into this looks really good. I left a comment on a concern for test failures based on static ports. Otherwise my only remaining concern is whether we've reviewed all of the transitive dependency changes/updates to ensure the License and Notice files are properly updated. This is critical. have you conducted that review of the dependencies before and after this change? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
