szaszm commented on a change in pull request #789: URL: https://github.com/apache/nifi-minifi-cpp/pull/789#discussion_r433719488
########## File path: libminifi/include/core/repository/AtomicRepoEntries.h ########## @@ -76,8 +78,7 @@ noexcept : key_(std::move(other.key_)), comparator_(std::move(other.comparator_)) { } - ~RepoValue() - { + ~RepoValue() { } Review comment: You're right, I didn't notice that this was not related to the goal of the PR. Your call whether you fix it and if so, whether it will be part of this PR or separate. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org