hunyadi-dev commented on a change in pull request #789:
URL: https://github.com/apache/nifi-minifi-cpp/pull/789#discussion_r433728480
##########
File path: libminifi/include/core/repository/VolatileProvenanceRepository.h
##########
@@ -31,14 +33,11 @@ namespace repository {
* Volatile provenance repository.
*/
class VolatileProvenanceRepository : public VolatileRepository<std::string> {
-
public:
explicit VolatileProvenanceRepository(std::string repo_name = "",
std::string dir = REPOSITORY_DIRECTORY, int64_t maxPartitionMillis =
MAX_REPOSITORY_ENTRY_LIFE_TIME, int64_t maxPartitionBytes =
MAX_REPOSITORY_STORAGE_SIZE,
uint64_t purgePeriod =
REPOSITORY_PURGE_PERIOD)
- :
core::SerializableComponent(repo_name),VolatileRepository(repo_name.length() >
0 ? repo_name : core::getClassName<VolatileRepository>(), "",
maxPartitionMillis, maxPartitionBytes, purgePeriod)
-
- {
+ : core::SerializableComponent(repo_name),
VolatileRepository(repo_name.length() > 0 ? repo_name :
core::getClassName<VolatileRepository>(), "", maxPartitionMillis,
maxPartitionBytes, purgePeriod) { // NOLINT
Review comment:
I agree to the proposal, though I think other contributors might have an
opinion on this. Let's discuss this separately.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
