markap14 commented on a change in pull request #4337:
URL: https://github.com/apache/nifi/pull/4337#discussion_r442334635
##########
File path:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java
##########
@@ -3332,6 +3336,38 @@ private ProcessorEntity createProcessorEntity(final
ProcessorNode processor, fin
.collect(Collectors.toSet());
}
+ @Override
+ public ProcessorsRunStatusDetailsEntity
getProcessorsRunStatusDetails(final Set<String> processorIds, final NiFiUser
user) {
+ final List<ProcessorRunStatusDetailsEntity> summaryEntities =
processorIds.stream()
+ .map(processorDAO::getProcessor)
+ .map(processor -> createRunStatusDetailsEntity(processor, user))
+ .collect(Collectors.toList());
+
+ final ProcessorsRunStatusDetailsEntity summariesEntity = new
ProcessorsRunStatusDetailsEntity();
+ summariesEntity.setRunStatusDetails(summaryEntities);
+ return summariesEntity;
+ }
+
+ private ProcessorRunStatusDetailsEntity createRunStatusDetailsEntity(final
ProcessorNode processor, final NiFiUser user) {
+ final RevisionDTO revision =
dtoFactory.createRevisionDTO(revisionManager.getRevision(processor.getIdentifier()));
+ final PermissionsDTO permissions =
dtoFactory.createPermissionsDto(processor, user);
+ final ProcessorStatus processorStatus =
controllerFacade.getProcessorStatus(processor.getIdentifier());
+ final ProcessorRunStatusDetailsDTO runStatusDetailsDto =
dtoFactory.createProcessorRunStatusDetailsDto(processor, processorStatus);
+
+ if (!Boolean.TRUE.equals(permissions.getCanRead())) {
Review comment:
@tpalfy DTO objects in nifi always use Objects rather than primitives
because a primitive would default to `false` and we don't want that - we want
the exact value that was set, including `null` potentially. Because it can be
`null`, we cannot use auto-boxing, as it could throw NPE
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
