markap14 commented on a change in pull request #4337: URL: https://github.com/apache/nifi/pull/4337#discussion_r442392977
########## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/StandardNiFiServiceFacade.java ########## @@ -3332,6 +3336,38 @@ private ProcessorEntity createProcessorEntity(final ProcessorNode processor, fin .collect(Collectors.toSet()); } + @Override + public ProcessorsRunStatusDetailsEntity getProcessorsRunStatusDetails(final Set<String> processorIds, final NiFiUser user) { + final List<ProcessorRunStatusDetailsEntity> summaryEntities = processorIds.stream() + .map(processorDAO::getProcessor) + .map(processor -> createRunStatusDetailsEntity(processor, user)) + .collect(Collectors.toList()); + + final ProcessorsRunStatusDetailsEntity summariesEntity = new ProcessorsRunStatusDetailsEntity(); + summariesEntity.setRunStatusDetails(summaryEntities); + return summariesEntity; + } + + private ProcessorRunStatusDetailsEntity createRunStatusDetailsEntity(final ProcessorNode processor, final NiFiUser user) { + final RevisionDTO revision = dtoFactory.createRevisionDTO(revisionManager.getRevision(processor.getIdentifier())); + final PermissionsDTO permissions = dtoFactory.createPermissionsDto(processor, user); + final ProcessorStatus processorStatus = controllerFacade.getProcessorStatus(processor.getIdentifier()); + final ProcessorRunStatusDetailsDTO runStatusDetailsDto = dtoFactory.createProcessorRunStatusDetailsDto(processor, processorStatus); + + if (!Boolean.TRUE.equals(permissions.getCanRead())) { Review comment: Actually, in this case I guess it doesn't matter - we know that the permissions always will be populated. So even though it's a Boolean, it's safe to assume that the value will be set. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org