fgerlits commented on a change in pull request #835:
URL: https://github.com/apache/nifi-minifi-cpp/pull/835#discussion_r451599406
##########
File path: extensions/http-curl/tests/HTTPIntegrationBase.h
##########
@@ -135,6 +135,9 @@ class VerifyC2Describe : public VerifyC2Base {
}
void runAssertions() override {
+ // This class is never used for running assertions, but we are forced to
wait for DescribeManifestHandler to verifyJsonHasAgentManifest
+ // if we were to log something on finished verification, we could poll on
finding it
+ std::this_thread::sleep_for(std::chrono::milliseconds(wait_time_));
Review comment:
Can the sleep go into `waitToVerifyProcessor()` and `runAssertion()` be
empty in this case? I think that would say in code what you say in the comment
above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
